Repository navigation
test: move limit fuzz tests to the FuzzTest driver - #27325
Merged
Merged
Conversation
2010YOUY01
reviewed
Nov 14, 2026
2010YOUY01
left a comment
Member
There was a problem hiding this comment.
Thank you!
Before merging, we should split the tests, so they can run on multiple threads.
Clean-up advices are optional.
Contributor
Author
|
Thanks, updated. I also fixed a typo in the input sizes: 1_0000 → 1_000. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FuzzTesttrait #27082.Rationale for this change
The TopK fuzz tests use an unseeded RNG and cannot reproduc failure. Moves them to the shared
FuzzTestdriver.What changes are included in this PR?
core/tests/fuzz_cases/limit_fuzz.rstofuzz/tests/suites/limit.rs.kselects the input sizeSIZES[k % 4]and the data seedk / 4. Each run has 4 cases, one for each size, as before.LimitFuzzerand theFUZZERStable register the 4 suites. The suite names are the old test names.What is the testing strategy for this PR?
I changed the TopK heap condition locally.
test_sort_topk_i32failed withTopK mismatchand printed the case seed.Are there any user-facing changes?
No